Having developer/committer comments from a github review automatically show up on dev@ lists will ease my concern that the git activities somehow avoid the "if it isn't on the mail lists, it didn't happen" requirement.
Craig On Feb 6, 2014, at 9:08 AM, Michael Joyce wrote: > How is doing a review on Github any different than doing a review on Review > Board? If there's concern that work on Github isn't being adequately > mirrored on the mailing lists then that sounds like an Infra problem to me. > There are plenty of hooks [1] that makes this easy to do and, if I'm not > mistaken, pull requests through Github are already supposed to mail dev@. I > would assume that any comment on them should as well. > > > [1] http://developer.github.com/v3/repos/hooks/ > > > -- Joyce > > > On Thu, Feb 6, 2014 at 1:22 AM, David Nalley <da...@gnsa.us> wrote: > >>> >>> If you look at the GitHub code reviews ( >> https://github.com/apache/incubator-spark/pulls), you'll see that lots of >> people are contributing to reviewing. But I agree that the new committer >> onboarding process should include having them do a test commit. >>> >> >> Matei: >> >> Reviews being done on github causes me a bit of concern. Generally >> dev@ should be the nexus for a project, and most of the projects that >> have github in the workflow ensure that pull requests get sent to dev@ >> so the discussions, reviews, and patches themselves are seen and >> archived there. >> >> I see that one of your mentors brought up similar concerns about this >> (as well as where discussions on strategy or roadmap happen) yesterday >> on dev@ - that doesn't leave me with warm fuzzy assurance that the >> project groks the Apache way. >> >> --David >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> Craig L Russell Architect, Oracle http://db.apache.org/jdo 408 276-5638 mailto:craig.russ...@oracle.com P.S. A good JDO? O, Gasp! --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
