Thanks for the feedback, I replied inline.
On Mar 27, 2013, at 21:00 , sebb wrote: > On 27 March 2013 19:07, Matthieu Morel <mmo...@apache.org> wrote: >> Hi everyone, >> >> >> this is a call for a vote to release Apache S4 0.6.0 incubating. >> >> >> A vote was held on developer mailing list and it passed for RC3 with 6+1's >> with 5 of them binding: >> >> +1 IPMC (phunt) >> +1PPMC (mmorel, kishoreg, leoneu, fpj) >> +1 committer non PPMC (dferro) >> >> >> Here is the vote thread on s4-dev: >> http://markmail.org/thread/n5totrx7jkh2nvzu >> >> >> This release fixes the following issues: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312322&version=12321702 >> >> >> Note that we are voting upon the source (tag), binaries are provided for >> convenience. >> >> Source and binary packages in zip format: >> >> http://people.apache.org/~mmorel/s4-0.6.0-incubating-release-candidate-3/ >> >> >> >> The (git) tag to be voted upon: 0.6.0-RC3: >> >> https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=tag;h=9b178170d76333579a9c56564dd060ccd173f115 > > NOTICE says: > > Apache S4 > Copyright 2012 The Apache Software Foundation > > Have there been no substantive changes this year? I think you are reading from the master branch in the git repository. In our development process (https://issues.apache.org/jira/browse/S4-35) the master branch holds the released code, while the dev branch holds the code accepted for inclusion and that will be part of the next release. So we cut the release candidate from dev branch. The year in the NOTICE file is 2013. > > gradlew and gradlew.bat don't have AL headers; nor does s4. The s4 file does have headers in the release artifacts. gradle/gradlew scripts to not have the ASL header because this is generated code. According to the RAT tool, generated code does not need to bear the license header. This issue was identified and discussed during the voting process on s4-dev mailing lis. For this release, it was considered valid to leave those generated files not annotated by one of our mentors. > > I did not bother to check the rest of the tree, but I assume there are > other files which are missing their AL headers. > > The file > > config/binrelease/LICENSE > > includes various sentences like: > > "This product uses kryo and minlog, which use the following license:" > > I think that is wrong; the LICENSE and NOTICE files should ONLY > include references to works that are *included* in the enclosing > archive. > > If the binary product does not include the 3rd party products, then > remove the LICENSE reference entirely. > > If it does *include* a 3rd party product, then change the LICENSE to > say so, and check whether the 3rd party license requires attribution. In the binary release, we do include 3rd party products and the NOTICE and LICENSE files are updated accordingly, during the build process. You may check the binary release artifact. In the source release, we do not include those products and the NOTICE and LICENSE files take that into account. > >> >> S4 KEYS file containing PGP keys we use to sign the release: >> >> http://svn.apache.org/repos/asf/incubator/s4/dist/KEYS > > The key entries don't have any human-readable headings, as required by > the comments. > For example: > > (gpg --list-sigs <your name> > && gpg --armor --export <your name>) >> > this file. > > The --list-sigs command creates a readable header. I followed the instructions for signing apache releases http://www.apache.org/dev/release-signing.html and didn't see requirement for human readable headings in the KEYS file. (and didn't understand the comments were mandating that) If this is a requirement for the release, I suppose I can update the KEYS file in the subversion repository with the proper headers? > >> >> We include a RAT check task. It requires to get >> - the .rat-excludes from the repository >> (https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=blob;f=.rat-excludes;h=fda230011164a53bd3089f9086c884918e0ea292;hb=refs/heads/dev) > > Why are the following excluded? > > logback.xml > s4-checkstyle.xml > s4-eclipse-format.xml > > XML supports header comments. There is no reason. Those files are for setting up the development environment and configuring the log output. Other xml files in the release do bear the ASL header. Is that blocking the release? I hope these explanations bring clarification. Regards, Matthieu > >> - the rat jar from the repository >> It can be run with : >> ./gradlew rat > output >> >> >> >> Please cast your vote, thanks! >> >> >> Vote will be open for 72 hours >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove (and reason why) >> >> >> Matthieu >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org >
