+1 (mentor and IPMC binding) Some thoughts, but nothing that I would consider a "show stopper" since this is a source only release (aka: not providing a prebuilt war type thing or deploying it to Maven central):
1) The README mentions a "Collective work: Copyright 2007", but the NOTICE starts the copyright at 2008. That said, I'd just remove the License section from the README entirely. 2) The tar unpacks into a "trunk" directory. That really should unpack into a "apache-esme-1.0" directory or similar. 3) The "version" number in the pom is still 0.3.0-SNAPSHOT. Thus, if you build it, you get a snapshot war. Not a "huge" deal if we're not providing a binary war, but a bit unusual and unexpected. 4) Snapshot dependencies. It has dependencies on snapshots from Lift. Not good for a "release" as the release isn't really reproducible. 5) Very minor suggestion: if you are Java 6 only, you could exclude things like activation.jar, xml-apis, and most likely xerces to make the war a little bit smaller.. As far as the legal bits go, looks ok for a source release, so +1. Dan On Mon February 15 2010 10:05:43 am Richard Hirsch wrote: > The ESME community has voted on and approved the release of ESME 1.0. > We would now like to request the approval of the Incubator PMC for > this release. > > Details of the ESME community vote can be found here: > http://mail-archives.apache.org/mod_mbox/incubator-esme-dev/201002.mbox/%3C > fa2d9f451002120649u54cdd8b5red151033d655b...@mail.gmail.com%3e > > The candidate can be found at: > > http://people.apache.org/~rhirsch/esme/ > > See the CHANGES.txt file for details on release contents. The release > candidate is a tar archive of the sources in > https://svn.apache.org/repos/asf/incubator/esme/tags/esme-1.0-incubating/ > > The MD5 checksum of the apache-esme-incubating-1.0- > src.tar.gz release package is > A4 9B 04 07 47 66 41 0C FE 01 2D 8B 5C 23 33 18 > > Please vote on releasing this package as Apache ESME 1.0-incubating. > > Please vote to publish this release by Thursday, Feb 18 16:03 CET, > please include the testing you performed to arrive at your vote > [ ] +1 Publish > [ ] 0 Abstain > [ ] -1 Don't publish, because... > > Below is a summary of the vote on the ESME mailing list > > Thanks > > Dick > > --------------- > > Sender-time Sent at 4:00 PM (GMT+01:00). Current time there: 4:04 PM. ✆ > to esme-...@incubator.apache.org > date Mon, Feb 15, 2010 at 4:00 PM > subject [VOTE][RESULT] ESME 1.0 > mailed-by gmail.com > > > Hello All, > > Voting on the ESME 1.0 candidate release has concluded > > Results: > > 6 binding +1 vote > > Dick Hirsch +1 > Mrinal Wadhwa +1 > Vassil Dichev +1 > Ethan Jewett +1 > Anne Kathrine Petteroe +1 > Darren Hague +1 > > 1 non-binding +1 votes > > Daniel Koller +1 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org -- Daniel Kulp dk...@apache.org http://www.dankulp.com/blog --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
