Ok, we have three +1's (Yoav, Garrett and Ant) and I have addressed the most significant issues raised by Kevan. I've given it about a weeks time to see if there are any additional issues. Unless there are any objections (or unless I'm getting some part of the process wrong ;-) ..) I'm going to assume that we're good to go for release.
- James Kevan Miller wrote: > > On Sep 27, 2007, at 12:45 PM, James M Snell wrote: > >> Ok, we have made a couple of bug fixes and, more importantly, we have >> softened the bouncy castle dependency and will no longer ship that jar. >> This release has been well tested and reviewed and has received the >> requisite number of +1's from the committers. >> >> The release candidate can be found here: >> >> http://people.apache.org/~jmsnell/abdera/0.3.0 > > Hi James, > I've taken a look at your binary and src downloads. I'm seeing the > following problems which, IMHO, most of these issues should be addressed. > > 1. No incubator DISCLAIMER in your generated Jar files. Your README > contains a DISCLAIMER notice. However, I think each of your jar files > needs to contain a disclaimer, also. > 2. No ASF Copyright in your NOTICE files. As described here -- > http://www.apache.org/legal/src-headers.html#notice. There should be a > copyright notice for the work that's occurring within the Abdera > project, itself. > 3. No LICENSE or NOTICE (or DISCLAIMER) files in > lib/abdera-i18n-0.3.0-incubating.jar of your binary distribution. > 4. Missing Apache source license headers. RAT is noting the following > files from your source are missing license headers. IMO, a number of > these files could and should have an Apache source license header. > > !????? ./client/src/main/java/log4j.properties > !????? > ./contrib/rss/src/main/resources/META-INF/services/org.apache.abdera.factory.ExtensionFactory > > !????? ./contrib/rss/src/test/resources/rss1.rdf > !????? > ./core/src/main/java/org/apache/abdera/util/XmlRestrictedCharReader.java > !????? ./core/src/main/resources/abdera.properties.example > !????? ./core/src/main/resources/abderamessages.properties > !????? > ./core/src/main/resources/META-INF/services/org.apache.abdera.factory.ExtensionFactory.example > > !????? ./dependencies/deps.properties > !????? ./dependencies/i18n/build.properties > !????? > ./dependencies/i18n/src/main/resources/org/apache/abdera/i18n/unicode/data/ucd.res > > !????? ./dependencies/legal/axiom-NOTICE.txt > !????? ./dependencies/legal/retroweaver-LICENSE.txt > !????? ./dependencies/legal/wstx-asl-NOTICE.txt > !????? ./dependencies/legal/xmlsec-NOTICE.txt > !????? ./docs/knownissues.txt > !????? ./examples/src/main/resources/content.xslt > !????? ./examples/src/main/resources/log4j.properties > !????? ./examples/src/main/resources/simple.xml > !????? ./examples/src/main/resources/test.xslt > !????? ./examples/src/main/resources/xmlcontent.xml > !????? > ./examples/src/main/resources/META-INF/services/org.apache.abdera.factory.ExtensionFactory > > !????? > ./examples/src/main/resources/org/apache/abdera/examples/appserver/web.xml > !????? > ./extensions/json/src/main/resources/META-INF/services/org.apache.abdera.writer.NamedWriter > > !????? > ./extensions/main/src/main/resources/META-INF/services/org.apache.abdera.factory.ExtensionFactory > > !????? > ./extensions/media/src/main/resources/META-INF/services/org.apache.abdera.factory.ExtensionFactory > > !????? > ./extensions/opensearch/src/main/resources/META-INF/services/org.apache.abdera.factory.ExtensionFactory > > !????? ./extensions/opensearch/src/test/resources/opensearch.xml > !????? > ./extensions/sharing/src/main/resources/META-INF/services/org.apache.abdera.factory.ExtensionFactory > > !????? > ./parser/src/main/resources/META-INF/services/org.apache.abdera.writer.NamedWriter > > !????? ./parser/src/test/resources/complete.xml > !????? ./parser/src/test/resources/content.xslt > !????? ./parser/src/test/resources/entry.xml > !????? ./parser/src/test/resources/feed.xml > !????? ./parser/src/test/resources/simple.xml > !????? ./parser/src/test/resources/simpleEntry.xml > !????? ./parser/src/test/resources/simpleFeed.xml > !????? ./parser/src/test/resources/simpleService.xml > !????? ./parser/src/test/resources/test.xslt > !????? ./parser/src/test/resources/xmlcontent.xml > !????? > ./parser/src/test/resources/www.feedparser.org/tests/wellformed/atom10/atom10_namespace.xml > > !????? > ./parser/src/test/resources/www.feedparser.org/tests/wellformed/atom10/entry_author_email.xml > > !????? > ./parser/src/test/resources/www.feedparser.org/tests/wellformed/atom10/entry_author_name.xml > > !????? > ./parser/src/test/resources/www.feedparser.org/tests/wellformed/atom10/entry_content_base64.xml > > !????? > ./parser/src/test/resources/www.feedparser.org/tests/wellformed/atom10/entry_content_base64_2.xml > > !????? > ./parser/src/test/resources/www.snellspace.com/public/contentsummary.xml > !????? ./parser/src/test/resources/www.snellspace.com/public/linktests.xml > !????? > ./parser/src/test/resources/www.snellspace.com/public/nondefaultnamespace.xml > > !????? > ./parser/src/test/resources/www.snellspace.com/public/nondefaultnamespace2.xml > > !????? > ./parser/src/test/resources/www.snellspace.com/public/nondefaultnamespace3.xml > > !????? ./parser/src/test/resources/www.snellspace.com/public/ordertest.xml > !????? ./parser/src/test/resources/www.snellspace.com/public/xmlbase.xml > !????? > ./protocol/src/main/resources/META-INF/services/org.apache.abdera.factory.ExtensionFactory > > !????? ./security/src/test/resources/log4j.properties > !????? ./spring/src/test/java/org/apache/abdera/spring/TestProvider.java > !????? ./spring/src/test/resources/org/apache/abdera/spring/beans.xml > > --kevan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
smime.p7s
Description: S/MIME Cryptographic Signature
