I'm not so sure any of these issues are serious enough to block the release so I'm going still to give it a +1.
Most of the missing license headers are not in significant files and the top level LICENSE is there in the distributions which is the main thing, and I don't think LICENSE/NOTICE/DISCLAIMER files are required within jar files included with in a distribution, they're only necessary when the jars are distributed separately ...ant On 9/27/07, Garrett Rooney <[EMAIL PROTECTED]> wrote: > > On 9/27/07, Kevan Miller <[EMAIL PROTECTED]> wrote: > > > 2. No ASF Copyright in your NOTICE files. As described here -- http:// > > www.apache.org/legal/src-headers.html#notice. There should be a > > copyright notice for the work that's occurring within the Abdera > > project, itself. > > Umm, yes it is. It's on line 6 and 7 of the file: > > This product includes software developed by > The Apache Software Foundation (http://www.apache.org/). > > > 4. Missing Apache source license headers. RAT is noting the following > > files from your source are missing license headers. IMO, a number of > > these files could and should have an Apache source license header. > > > > !????? ./client/src/main/java/log4j.properties > > !????? ./contrib/rss/src/main/resources/META-INF/services/ > > org.apache.abdera.factory.ExtensionFactory > > !????? ./contrib/rss/src/test/resources/rss1.rdf > > !????? ./core/src/main/java/org/apache/abdera/util/ > > XmlRestrictedCharReader.java > > !????? ./core/src/main/resources/abdera.properties.example > > !????? ./core/src/main/resources/abderamessages.properties > > !????? ./core/src/main/resources/META-INF/services/ > > org.apache.abdera.factory.ExtensionFactory.example > > !????? ./dependencies/deps.properties > > !????? ./dependencies/i18n/build.properties > > !????? ./dependencies/i18n/src/main/resources/org/apache/abdera/i18n/ > > unicode/data/ucd.res > > !????? ./dependencies/legal/axiom-NOTICE.txt > > !????? ./dependencies/legal/retroweaver-LICENSE.txt > > !????? ./dependencies/legal/wstx-asl-NOTICE.txt > > !????? ./dependencies/legal/xmlsec-NOTICE.txt > > !????? ./docs/knownissues.txt > > !????? ./examples/src/main/resources/content.xslt > > !????? ./examples/src/main/resources/log4j.properties > > !????? ./examples/src/main/resources/simple.xml > > !????? ./examples/src/main/resources/test.xslt > > !????? ./examples/src/main/resources/xmlcontent.xml > > !????? ./examples/src/main/resources/META-INF/services/ > > org.apache.abdera.factory.ExtensionFactory > > !????? ./examples/src/main/resources/org/apache/abdera/examples/ > > appserver/web.xml > > !????? ./extensions/json/src/main/resources/META-INF/services/ > > org.apache.abdera.writer.NamedWriter > > !????? ./extensions/main/src/main/resources/META-INF/services/ > > org.apache.abdera.factory.ExtensionFactory > > !????? ./extensions/media/src/main/resources/META-INF/services/ > > org.apache.abdera.factory.ExtensionFactory > > !????? ./extensions/opensearch/src/main/resources/META-INF/services/ > > org.apache.abdera.factory.ExtensionFactory > > !????? ./extensions/opensearch/src/test/resources/opensearch.xml > > !????? ./extensions/sharing/src/main/resources/META-INF/services/ > > org.apache.abdera.factory.ExtensionFactory > > !????? ./parser/src/main/resources/META-INF/services/ > > org.apache.abdera.writer.NamedWriter > > !????? ./parser/src/test/resources/complete.xml > > !????? ./parser/src/test/resources/content.xslt > > !????? ./parser/src/test/resources/entry.xml > > !????? ./parser/src/test/resources/feed.xml > > !????? ./parser/src/test/resources/simple.xml > > !????? ./parser/src/test/resources/simpleEntry.xml > > !????? ./parser/src/test/resources/simpleFeed.xml > > !????? ./parser/src/test/resources/simpleService.xml > > !????? ./parser/src/test/resources/test.xslt > > !????? ./parser/src/test/resources/xmlcontent.xml > > !????? ./parser/src/test/resources/www.feedparser.org/tests/ > > wellformed/atom10/atom10_namespace.xml > > !????? ./parser/src/test/resources/www.feedparser.org/tests/ > > wellformed/atom10/entry_author_email.xml > > !????? ./parser/src/test/resources/www.feedparser.org/tests/ > > wellformed/atom10/entry_author_name.xml > > !????? ./parser/src/test/resources/www.feedparser.org/tests/ > > wellformed/atom10/entry_content_base64.xml > > !????? ./parser/src/test/resources/www.feedparser.org/tests/ > > wellformed/atom10/entry_content_base64_2.xml > > !????? ./parser/src/test/resources/www.snellspace.com/public/ > > contentsummary.xml > > !????? ./parser/src/test/resources/www.snellspace.com/public/ > > linktests.xml > > !????? ./parser/src/test/resources/www.snellspace.com/public/ > > nondefaultnamespace.xml > > !????? ./parser/src/test/resources/www.snellspace.com/public/ > > nondefaultnamespace2.xml > > !????? ./parser/src/test/resources/www.snellspace.com/public/ > > nondefaultnamespace3.xml > > !????? ./parser/src/test/resources/www.snellspace.com/public/ > > ordertest.xml > > !????? ./parser/src/test/resources/www.snellspace.com/public/xmlbase.xml > > !????? ./protocol/src/main/resources/META-INF/services/ > > org.apache.abdera.factory.ExtensionFactory > > !????? ./security/src/test/resources/log4j.properties > > !????? ./spring/src/test/java/org/apache/abdera/spring/TestProvider.java > > !????? ./spring/src/test/resources/org/apache/abdera/spring/beans.xml > > If you're going to paste RAT output into an email, at least filter it > for sanity. There are a few files in here that legitimately need > fixing (most of them end in .java), but test files that contain > representative XML that's being parsed for test purposes shouldn't > have big license headers that are unlikely to show up in the real > world, and properties files that are two lines long and parsed at > runtime shouldn't be burdened with a license header that's multiple > times larger than they are, and both of these points have been > discussed in previous release threads for abdera. > > The other comments in your mail are valid, and I'm sure James will fix > them along with the few files that do have license header problems and > reroll the zips. > > -garrett > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
