Background for those who may be unaware of GenART:
GenART is the Area Review Team for the General Area of the IETF.
We advise the General Area Director (i.e. the IETF/IESG chair) by
providing more in depth reviews than he could do himself of documents
that come up for final decision in IESG telechat. I was selected
as the GenART member to review these documents. Below is my review,
which was written specifically with an eye to the GenART process, but
since I believe that it will be useful to have these comments more
widely distributed, others outside the GenART group are included.
Review criteria for WG submissions: "Is the document a reasonable
contribution to the area of Internet engineering which it covers? If
not, what changes would make it so?"
These drafts are basically ready for publication, but have nits that
should be fixed before publication.
The requirements draft needs enough attention that a new version
would be a good idea, especially as there may be a technical issue
hidden in Section 4.1's discussion of why ICMP is insufficient for
MPLS OAM purposes. The conclusion that ICMP is insufficient is
correct, but some of the examples that are used to support the
conclusion may be incorrect about control-vs-data-plane handling
of ICMP by MPLS LSRs.
The framework draft is in much better shape, as the minor issues
identified below appear to be reasonable to address via an RFC
Editor Note.
This email needs prompt attention, as Alex is requesting expedited
publication of these two drafts.
-- draft-ietf-mpls-oam-requirements-06.txt
I found a significant number of typos and English language
editorial cleanup nits that I'll leave to the RFC Editor to
address. It might be good to alert the RFC Editor that this
draft is likely to require heavy editorial attention.
Section 2.1 Terminology - Both "Head-end Label Switch
Router (LSR)" and "Head-end Label Switching Router (LSR)"
are defined. Only one of these two definitions should be
used - the other should be removed.
Section 2.2 Acronyms -
LSP: Label Switch Path
LSR: Label Switch Router
I suspect those should be "Label Switched Path" and "Label
Switching Router". In any case, between this and the previous
comment, consistency on whether "LS" in acronyms stands for
"Label Switch" vs. "Label Switched" and/or "Label Switching"
is needed throughout the draft.
Section 3 Motivations - RFC 2119 terminology is not appropriate
in this section, as it does not express requirements. Change
all occurrences of "MAY" to "may".
The statement that:
However as of this writing, existing drafts focus on single
provider solutions or focus on a single aspect of the MPLS
architecture or application of MPLS.
appears to be inconsistent with Section 4.9's discussion of
standard MPLS MIBs, which includes references to the RFCs that
specify them. In addition, this statement will be dramatically
incorrect when the LSP Ping draft is published. It should be
rewritten to be more about the drafts that respond to these
requirements rather than a criticism of what has gone before.
Section 4.1 Detection of Label Switched Path Defects
The characterization of "reasonable amount of time" for
detection as "both predictable and consistent" is incomplete.
For example, always detecting defects 47-48 hours after they
manifest in customer traffic is "both predictable and
consistent", but not "reasonable". A ballpark/approximate
order-of-magnitude discussion should be added covering the
time frames in which LSP defects will likely affect customer
traffic, and the detection timeframes required for operator
detection to precede customers noticing that something is
wrong.
The discussion of ICMP-based ping appears to assume that
ICMP-based ping is an MPLS control plane function, even at
LSRs that only forward an ICMP packet (i.e., not the destination
of the ICMP packet, and not the node at which the TTL hits zero).
If that assumption is correct, it needs to be stated, but it
does not appear to be consistent with RFC 3032's discussion
of ICMP and MPLS, which specifically states that ICMP packets
can be label switched. If ICMP-based ping goes through the
data plane as long as the TTL has not expired (which is what
I would expect), then this paragraph needs to be reworked.
Section 4.4 Service Level Agreement Measurement
... the qualitative
aspects of LSPs such as jitter, delay, latency and loss
I believe "quantitative" should be substituted for "qualitative".
Section 4.5 Frequency of OAM Execution
... probe-based detection mechanisms
that incur significant mismatches in the probe rate
That doesn't parse for me - what is mismatched to what? If
it's the rates of probing by multiple probe-based mechanisms,
the text quoted above should read:
... probe frequency or rate differences among multiple
probe-based detection mechanisms
At the end of the section, I understand how synchronizing
probe rates helps address the problem of inconsistent views of
network problem state, but explanation is needed for how
"having the probes self-identify their probe rate" helps.
Section 4.11 Per-LSP Accounting Requirements - ASBR acronym
used without expansion or definition.
Section 4.11.1 Requirements - The use of the word "key" in
(4) invites confusion with security usage of that word.
Please pick another term such as "tag" or "identifier",
unless there is a specific need to use "key".
Section 4.11.2 Scalability - This is not about "scalability"
per se, but rather minimum accounting requirements motivated
by scaling considerations. It should be retitled to "Location
of Accounting" or something like that.
Section 5 Security Considerations
The term "tools" in the first paragraph should be changed
to "network mechanisms", which is I believe this paragraph
is primarily about (e.g., authorization restrictions on use
of LSP Ping); tools is susceptible to being misread as being
primarily about the software applications that inspect the
network as opposed to the network mechanisms they use.
Sections 6 and 11 on IANA Considerations are duplicative
(but consistent). Remove one of them.
-- draft-ietf-mpls-oam-frmwk-03.txt
Section 3.1.1 Enumeration and Detection ...
Discontinuities in the MPLS Encapsulation paragraph -
FEC acronym used without prior expansion or definition.
Misordering paragraph - mention of TCP's ability to correct
misordered received packets should also point out that
misordering can cause TCP to retransmit some of the misordered
packets. This is important in order to not leave the impression
that TCP is insensitive to misordering.
Figure 1 is split across pages.
Section 7 Security Management - please weaken the following wording
in the second paragraph:
OAM messaging does address existing security concerns with the
MPLS architecture. i.e. through rigorous defect handling ...
To:
OAM messaging can address an existing security concern with the
MPLS architecture, as through rigorous defect handling ...
The original text could be misread to imply that all security
concerns can be addressed via OAM messaging, which is definitely
not intended.
Third paragraph - what is "trusted space"? If this is "a single
provider's network", use that terminology instead.
Thanks,
--David
----------------------------------------------------
David L. Black, Senior Technologist
EMC Corporation, 176 South St., Hopkinton, MA 01748
+1 (508) 293-7953 FAX: +1 (508) 293-7786
[EMAIL PROTECTED] Mobile: +1 (978) 394-7754
----------------------------------------------------
_______________________________________________
Gen-art mailing list
[email protected]
https://www1.ietf.org/mailman/listinfo/gen-art