Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/55592 )
Change subject: arch-x86: Truncate RIPs properly in the wrip microop.
......................................................................
arch-x86: Truncate RIPs properly in the wrip microop.
For all instructions which affect the RIP, they are supposed to
truncate/zero extend the RIP based on the width of the instruction. We
should do that after the target is calculated by adding the two operands
together, but before adding in the segment base address.
Change-Id: I105e58de6a07c7aa3155a9a188d8877c2955651f
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55592
Tested-by: kokoro <[email protected]>
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/arch/x86/isa/microops/regop.isa
1 file changed, 19 insertions(+), 1 deletion(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/x86/isa/microops/regop.isa
b/src/arch/x86/isa/microops/regop.isa
index d37cb6f..d56e17c 100644
--- a/src/arch/x86/isa/microops/regop.isa
+++ b/src/arch/x86/isa/microops/regop.isa
@@ -1162,7 +1162,7 @@
code = 'DoubleBits = PSrcReg1 ^ op2;'
class Wrip(WrRegOp, CondRegOp):
- code = 'NRIP = PSrcReg1 + sop2 + CSBase;'
+ code = 'NRIP = ((SrcReg1 + sop2) & mask(dataSize * 8)) + CSBase;'
else_code = "NRIP = NRIP;"
class Wruflags(WrRegOp):
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55592
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I105e58de6a07c7aa3155a9a188d8877c2955651f
Gerrit-Change-Number: 55592
Gerrit-PatchSet: 13
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bradford Beckmann <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
