Hi Gabe, The DPRINTF_UNCONDITIONAL macro has been deprecated in develop [1] and the deprecation is going to be official in v21.1. As far as I understood, the reason why it has been deprecated is because it was not used in gem5.
I am proposing to remove the deprecation. IMO that macro is useful when the Debug flag has already been checked outside of the Debug print. We recently merged a patch [2] that would have benefitted from the use of DPRINTF_UNCONDITIONAL. I am quite confident I can find some other parts of gem5 where the DPRINTF_UNCONDITIONAL would have been a better printing choice. I believe speed should still be a prime concern even if we are tracing, to make the debugging process faster and smoother for our users, especially As it comes with no cost (the definition of a macro) Let me know what you think about this, and if you don't have any objection I will push a revert of the patch you posted, and I will convert some DPRINT into a DPRINTF_UNCONDITIONAL Kind Regards Giacomo [1]: https://gem5-review.googlesource.com/c/public/gem5/+/44987 [2]: https://gem5-review.googlesource.com/c/public/gem5/+/47199/7/src/mem/cache/prefetch/queued.cc#134 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list -- [email protected] To unsubscribe send an email to [email protected] %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
