Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/44965 )
Change subject: arch-riscv, arch-x86: Define unique PageTableWalker flag
......................................................................
arch-riscv, arch-x86: Define unique PageTableWalker flag
Rather than defining multiple flags (one per ISA), we should define
a single PageTableWalker flag shared by all ISAs
Change-Id: Iad460bcd9a69d5c6f90443e43feec318429165aa
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/44965
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/generic/SConscript
M src/arch/riscv/SConscript
M src/arch/x86/SConscript
3 files changed, 2 insertions(+), 4 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/generic/SConscript b/src/arch/generic/SConscript
index 3ad4878..fb144f9 100644
--- a/src/arch/generic/SConscript
+++ b/src/arch/generic/SConscript
@@ -47,6 +47,8 @@
SimObject('BaseTLB.py')
SimObject('ISACommon.py')
+DebugFlag('PageTableWalker',
+ "Page table walker state machine debugging")
DebugFlag('TLB')
if env['TARGET_ISA'] == 'null':
diff --git a/src/arch/riscv/SConscript b/src/arch/riscv/SConscript
index 03e382c..291499c 100644
--- a/src/arch/riscv/SConscript
+++ b/src/arch/riscv/SConscript
@@ -75,8 +75,6 @@
DebugFlag('RiscvMisc')
DebugFlag('TLBVerbose')
DebugFlag('PMP')
- DebugFlag('PageTableWalker', \
- "Page table walker state machine debugging")
# Add in files generated by the ISA description.
ISADesc('isa/main.isa')
diff --git a/src/arch/x86/SConscript b/src/arch/x86/SConscript
index f790ec1..d7da290 100644
--- a/src/arch/x86/SConscript
+++ b/src/arch/x86/SConscript
@@ -77,8 +77,6 @@
DebugFlag('Faults', "Trace all faults/exceptions/traps")
DebugFlag('LocalApic', "Local APIC debugging")
-DebugFlag('PageTableWalker', \
- "Page table walker state machine debugging")
DebugFlag('Decoder', "Decoder debug output")
DebugFlag('X86', "Generic X86 ISA debugging")
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/44965
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iad460bcd9a69d5c6f90443e43feec318429165aa
Gerrit-Change-Number: 44965
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
