Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/39660 )
Change subject: base: Delete the unused RemoteGDB::(set|
clear)TempBreakpoint methods.
......................................................................
base: Delete the unused RemoteGDB::(set|clear)TempBreakpoint methods.
These are not used by anything, and use the ISA specific
TheISA::MachInst type.
Change-Id: Iae08e672b00834ccc5f11295b4c4529fbe7f8d0e
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39660
Reviewed-by: Bobby R. Bruce <bbr...@ucdavis.edu>
Reviewed-by: Daniel Carvalho <oda...@yahoo.com.br>
Maintainer: Bobby R. Bruce <bbr...@ucdavis.edu>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/base/remote_gdb.cc
M src/base/remote_gdb.hh
2 files changed, 0 insertions(+), 18 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, but someone else must approve
Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/remote_gdb.cc b/src/base/remote_gdb.cc
index 1e86a69..02cb11a 100644
--- a/src/base/remote_gdb.cc
+++ b/src/base/remote_gdb.cc
@@ -712,21 +712,6 @@
}
void
-BaseRemoteGDB::clearTempBreakpoint(Addr &bkpt)
-{
- DPRINTF(GDBMisc, "setTempBreakpoint: addr=%#x\n", bkpt);
- removeHardBreak(bkpt, sizeof(TheISA::MachInst));
- bkpt = 0;
-}
-
-void
-BaseRemoteGDB::setTempBreakpoint(Addr bkpt)
-{
- DPRINTF(GDBMisc, "setTempBreakpoint: addr=%#x\n", bkpt);
- insertHardBreak(bkpt, sizeof(TheISA::MachInst));
-}
-
-void
BaseRemoteGDB::scheduleInstCommitEvent(Event *ev, int delta)
{
// Here "ticks" aren't simulator ticks which measure time, they're
diff --git a/src/base/remote_gdb.hh b/src/base/remote_gdb.hh
index c71abfe..cbfb46f 100644
--- a/src/base/remote_gdb.hh
+++ b/src/base/remote_gdb.hh
@@ -257,9 +257,6 @@
void insertHardBreak(Addr addr, size_t len);
void removeHardBreak(Addr addr, size_t len);
- void clearTempBreakpoint(Addr &bkpt);
- void setTempBreakpoint(Addr bkpt);
-
/*
* GDB commands.
*/
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39660
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iae08e672b00834ccc5f11295b4c4529fbe7f8d0e
Gerrit-Change-Number: 39660
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
