Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/34977 )
Change subject: cpu: Remove unused demapInstPage and demapDataPage
......................................................................
cpu: Remove unused demapInstPage and demapDataPage
Change-Id: Iecc2ee8d91bfd3caf38e5f27e9689b7e0d488ed5
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34977
Reviewed-by: Gabe Black <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/cpu/base_dyn_inst.hh
M src/cpu/checker/cpu.hh
M src/cpu/minor/exec_context.hh
M src/cpu/o3/cpu.hh
M src/cpu/simple_thread.hh
5 files changed, 0 insertions(+), 54 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/base_dyn_inst.hh b/src/cpu/base_dyn_inst.hh
index f5018f3..9fe5b53 100644
--- a/src/cpu/base_dyn_inst.hh
+++ b/src/cpu/base_dyn_inst.hh
@@ -296,16 +296,6 @@
{
cpu->demapPage(vaddr, asn);
}
- void
- demapInstPage(Addr vaddr, uint64_t asn)
- {
- cpu->demapPage(vaddr, asn);
- }
- void
- demapDataPage(Addr vaddr, uint64_t asn)
- {
- cpu->demapPage(vaddr, asn);
- }
Fault initiateMemRead(Addr addr, unsigned size, Request::Flags flags,
const std::vector<bool> &byte_enable) override;
diff --git a/src/cpu/checker/cpu.hh b/src/cpu/checker/cpu.hh
index 49432f0..5213026 100644
--- a/src/cpu/checker/cpu.hh
+++ b/src/cpu/checker/cpu.hh
@@ -557,18 +557,6 @@
AddressMonitor *getAddrMonitor() override
{ return BaseCPU::getCpuAddrMonitor(0); }
- void
- demapInstPage(Addr vaddr, uint64_t asn)
- {
- mmu->itb->demapPage(vaddr, asn);
- }
-
- void
- demapDataPage(Addr vaddr, uint64_t asn)
- {
- mmu->dtb->demapPage(vaddr, asn);
- }
-
/**
* Helper function used to generate the request for a single fragment
of a
* memory access.
diff --git a/src/cpu/minor/exec_context.hh b/src/cpu/minor/exec_context.hh
index 6dc14b2..153fe29 100644
--- a/src/cpu/minor/exec_context.hh
+++ b/src/cpu/minor/exec_context.hh
@@ -451,18 +451,6 @@
thread.setCCReg(reg.index(), val);
}
- void
- demapInstPage(Addr vaddr, uint64_t asn)
- {
- thread.getITBPtr()->demapPage(vaddr, asn);
- }
-
- void
- demapDataPage(Addr vaddr, uint64_t asn)
- {
- thread.getDTBPtr()->demapPage(vaddr, asn);
- }
-
BaseCPU *getCpuPtr() { return &cpu; }
public:
diff --git a/src/cpu/o3/cpu.hh b/src/cpu/o3/cpu.hh
index 230ed95..57c855b 100644
--- a/src/cpu/o3/cpu.hh
+++ b/src/cpu/o3/cpu.hh
@@ -197,16 +197,6 @@
mmu->demapPage(vaddr, asn);
}
- void demapInstPage(Addr vaddr, uint64_t asn)
- {
- mmu->itb->demapPage(vaddr, asn);
- }
-
- void demapDataPage(Addr vaddr, uint64_t asn)
- {
- mmu->dtb->demapPage(vaddr, asn);
- }
-
/** Ticks CPU, calling tick() on each stage, and checking the overall
* activity to see if the CPU should deschedule itself.
*/
diff --git a/src/cpu/simple_thread.hh b/src/cpu/simple_thread.hh
index ad50414..e2f8070 100644
--- a/src/cpu/simple_thread.hh
+++ b/src/cpu/simple_thread.hh
@@ -174,16 +174,6 @@
mmu->demapPage(vaddr, asn);
}
- void demapInstPage(Addr vaddr, uint64_t asn)
- {
- mmu->itb->demapPage(vaddr, asn);
- }
-
- void demapDataPage(Addr vaddr, uint64_t asn)
- {
- mmu->dtb->demapPage(vaddr, asn);
- }
-
/*******************************************
* ThreadContext interface functions.
******************************************/
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/34977
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iecc2ee8d91bfd3caf38e5f27e9689b7e0d488ed5
Gerrit-Change-Number: 34977
Gerrit-PatchSet: 15
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
