Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32921 )
Change subject: arch: Make ThreadInfo::curThreadInfo virtual, protected.
......................................................................
arch: Make ThreadInfo::curThreadInfo virtual, protected.
Also remove it's Alpha centric implementation. All existing ISAs will
panic since they all define the guarding constant as false. Even if they
defined it as true, this function assumes that there is necessarily a misc
reg which can be read to find the current thread_info struct, and how
the contents of that register should be manipulated.
This code is already fairly fragile since it depends on things in the
Linux kernel having certain names and relationships with each other, but
that's a larger problem I don't want to fix right now.
Change-Id: Ic107793ebcd25ee25c4d3713c84c1d2b5209f1a3
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32921
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/generic/linux/threadinfo.hh
1 file changed, 2 insertions(+), 14 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/generic/linux/threadinfo.hh
b/src/arch/generic/linux/threadinfo.hh
index 7bbf2df..0127105 100644
--- a/src/arch/generic/linux/threadinfo.hh
+++ b/src/arch/generic/linux/threadinfo.hh
@@ -71,22 +71,10 @@
~ThreadInfo()
{}
- Addr
+ virtual Addr
curThreadInfo()
{
- if (!TheISA::CurThreadInfoImplemented)
- panic("curThreadInfo() not implemented for this ISA");
-
- Addr addr = pcbb;
- Addr sp;
-
- if (!addr)
- addr = tc->readMiscRegNoEffect(TheISA::CurThreadInfoReg);
-
- PortProxy &p = tc->getPhysProxy();
- p.readBlob(addr, &sp, sizeof(Addr));
-
- return sp & ~ULL(0x3fff);
+ panic("curThreadInfo() not implemented.");
}
Addr
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32921
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic107793ebcd25ee25c4d3713c84c1d2b5209f1a3
Gerrit-Change-Number: 32921
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Dam Sunwoo <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
