On 1/7/2022 7:49 AM, Jeff Law wrote:
On 1/7/2022 3:25 AM, Martin Jambor wrote:
Hi,
Would anyone be terribly against mass renaming all *.c files (that are
actually C++ files) within the gcc subdirectory to ones with .cc suffix?
We already have 47 files with suffix .cc directly in the gcc
subdirectory and 160 if we also count those in (non-testsuite)
subdirectories, while the majority of our non-header C++ files still has
the .c suffix.
I have already missed stuff when grepping because I did not include *.cc
files and the inconsistency is also just ugly and must be very confusing
to anyone who encounters it for the first time.
Since we have switched to git, this should have quite small effect on
anyone who does their development on branches. With Martin Liška we did
a few experiments and git blame, git rebase and even git gcc-backport
worked seamlessly across a rename.
I would be fine waiting with it until GCC 12 gets released but see
little value in doing so.
What do others think? (Any important caveats I might have missed?)
I think it's well past time we do this. There may be a bit of pain
with cherry-picking across the rename point, but we should just deal
with it.
I realized this might be mis-interpreted. The "well past time" was
really meant to signal that I think we probably should have made this
change long ago and that waiting even longer just doesn't make sense to me.
I'm fully in favor and have no objections to making it now. I wouldn't
be terribly surprised if it's less intrusive to make now rather than
after gcc-12 is released. Making it now affects trunk->gcc11 and
earlier backports which should be smaller than trunk->gcc-12 backports
we'd be making in the summer/fall if we were to defer until after gcc-12.
jeff
