Hello.

Note that binutils updated the git-hooks, which now uses Python 3:
https://github.com/AdaCore/git-hooks

I'm asking because we're facing again an encoding issue (spotted by Jakub):

<jakub> remote: Traceback (most recent call last):
<jakub> remote:   File "hooks/post_receive.py", line 118, in <module>
<jakub> remote:     post_receive(refs_data, args.submitter_email)
<jakub> remote:   File "hooks/post_receive.py", line 65, in post_receive
<jakub> remote:     submitter_email)
<jakub> remote:   File "hooks/post_receive.py", line 47, in post_receive_one
<jakub> remote:     update.send_email_notifications()
<jakub> remote:   File 
"/sourceware1/projects/src-home/git-hooks/hooks/updates/__init__.py", line 189, in 
send_email_notifications
<jakub> remote:     self.__email_new_commits()
<jakub> remote:   File 
"/sourceware1/projects/src-home/git-hooks/hooks/updates/__init__.py", line 1031, in 
__email_new_commits
<jakub> remote:     commit, self.get_standard_commit_email(commit))
<jakub> remote:   File 
"/sourceware1/projects/src-home/git-hooks/hooks/updates/__init__.py", line 1011, in 
__send_commit_email
<jakub> remote:     default_diff=email.diff)
<jakub> remote:   File 
"/sourceware1/projects/src-home/git-hooks/hooks/updates/__init__.py", line 946, in 
__maybe_get_email_custom_contents
<jakub> remote:     hook_input=json.dumps(hooks_data),
<jakub> remote:   File "/usr/lib64/python2.7/json/__init__.py", line 244, in 
dumps
<jakub> remote:     return _default_encoder.encode(obj)
<jakub> remote:   File "/usr/lib64/python2.7/json/encoder.py", line 207, in 
encode
<jakub> remote:     chunks = self.iterencode(o, _one_shot=True)
<jakub> remote:   File "/usr/lib64/python2.7/json/encoder.py", line 270, in 
iterencode
<jakub> remote:     return _iterencode(o, 0)
<jakub> remote: UnicodeDecodeError: 'utf8' codec can't decode byte 0xe9 in 
position 7675115: invalid continuation byte

So can we please update the hooks?

Thanks,
Martin

Reply via email to