Hi, On Wed, 2021-09-15 at 14:43 +0100, Jonathan Wakely via Gcc wrote: > On Wed, 15 Sept 2021 at 14:37, Jan-Benedict Glaw <jbg...@lug-owl.de> > wrote: > > On Wed, 2021-09-15 09:21:04 -0400, David Malcolm via Gcc < > > gcc@gcc.gnu.org> wrote: > > > It appears to be due to the "ł" character in the email address of > > > the > > > Author, in that: > > > > > > commit c012297c9d5dfb177adf1423bdd05e5f4b87e5ec > > > Author: Jan-Benedict Glaw <jbg...@lug-owl.de> > > > > > > works, whereas: > > > > > > commit f42e95a830ab48e59389065ce79a013a519646f1 > > > Author: Jan-Benedict Glaw <jbglaw@ług-owl.de> > > > > That was indeed me, after moving my GCC repo to a different machine > > and adding an explicit user.email (as this wasn't automatically > > picking up a proper domain.) The "ł" was a typo (AltGr key still > > pressed while typing the "l" after having entered the "@" which > > requires it on a German keyboard layout.) > > > > So I broke it. Any way to make sure something like this doesn't > > occur again? > > We could add a check to the git hooks (and gcc-verify alias) to > reject > non-ASCII email addresses, since they're probably mistakes. > > And we should report it to Gitweb (if it isn't already fixed > upstream) > and get a fix into the version used on gcc.gnu.org.
The issue is the gravatar support, which calls md5_hex($email). For now I disabled gravatar support on sourceware.org/gcc.gnu.org in /etc/gitweb.conf Cheers, Mark
