Hi,
You are supposed to be able to post once you've subscribed.
Also, GCC's code analysis is wrong. "name_bf" contains *NO MORE* than
MAXNAMELEN characters. That is provable.
"def_str" points into a buffer of size ((MAXNAMELEN * 2) + 8) and at an
offset maximum of MAXNAMELEN+1 (also provable), meaning that at a
minimum there are MAXNAMELEN+6 bytes left in the buffer.
That objected-to sprintf can add a maximum of MAXNAMELEN + 4 to where
"def_str" points.
GCC is wrong. It is unable to figure out how far into the buffer
"def_str" can point.
On 1/8/21 2:26 AM, Oppe, Thomas C ERDC-RDE-ITL-MS Contractor wrote:
Dear Sir:
I would like to post the following message to the mailing list
"autogen-us...@lists.sourceforge.net". Could you please add me to this list?
I am an HPC user at ERDC DSRC in Vicksburg, MS. One of my projects is building GCC
snapshots and releases using various software prerequisite packages necessary in the
"make check" phase. One of these packages is autogen-5.18.16.
Thank you for your consideration.
Tom Oppe
-----------------------------------------------------------------------------
Thomas C. Oppe
HPCMP Benchmarking Team
HITS Team SAIC
thomas.c.o...@erdc.dren.mil
Work: (601) 634-2797
Cell: (601) 642-6391
-----------------------------------------------------------------------------
________________________________________
From: Oppe, Thomas C ERDC-RDE-ITL-MS Contractor
Sent: Friday, January 8, 2021 12:32 AM
To: autogen-us...@lists.sourceforge.net
Subject: Problems with compiling autogen with GCC8 or newer versions
Dear Sir:
When compiling autogen-5.18.16 with gcc8 or newer, I am getting format overflow errors
like the following during the "make" step:
top_builddir=".." top_srcdir=".." VERBOSE="" /bin/bash "../build-aux/run-ag.sh"
-MFstamp-opts -MTstamp-opts -MP ./opts.def
gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../autoopts -g -O2
-I/p/home/oppe/gcc/10.2.0/include -Wno-format-contains-nul -fno-strict-aliasing
-Wall -Werror -Wcast-align -Wmissing-prototypes -Wpointer-arith -Wshadow
-Wstrict-prototypes -Wwrite-strings -Wstrict-aliasing=3 -Wextra -Wno-cast-qual
-g -O2 -I/p/home/oppe/gcc/10.2.0/include -Wno-format-contains-nul
-fno-strict-aliasing -c -o gd.o gd.c
In file included from gd.c:11:
getdefs.c: In function 'buildDefinition':
getdefs.c:451:29: error: '%s' directive writing up to 255 bytes into a region
of size 253 [-Werror=format-overflow=]
451 | sprintf(def_str, " %s'", name_bf);
| ^~ ~~~~~~~
getdefs.c:451:9: note: 'sprintf' output between 4 and 259 bytes into a
destination of size 255
451 | sprintf(def_str, " %s'", name_bf);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [gd.o] Error 1
make[2]: Leaving directory `/p/work1/oppe/autogen-5.18.16/getdefs'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/p/work1/oppe/autogen-5.18.16'
make: *** [all] Error 2
Do I just add "-Wno-error=format-overflow" to the compile options? Do you have
a fix?
Tom Oppe
-----------------------------------------------------------------------------
Thomas C. Oppe
HPCMP Benchmarking Team
HITS Team SAIC
thomas.c.o...@erdc.dren.mil
Work: (601) 634-2797
Cell: (601) 642-6391
-----------------------------------------------------------------------------
