On Tue, 2020-05-19 at 13:03 -0600, Martin Sebor via Gcc wrote: > I'm having trouble with the commit hook that tries to enforce > ChangeLog contents. It fails with an error that doesn't make > sense to me: the file it complains isn't mentioned clearly is > listed there and I can't tell what about how it's mentioned > the hook is having a problem with.
If it's a bug in the hook, it would probably be helpful if you posted the commit that it refused to accept. It looks to me like when the hook parsed the patch part of your commit that it erroneously decided the hunks changing gcc/cp/cp-tree.c were actually to "gcc/cp/tree.c" - but that's guesswork on my part. Hope this is helpful Dave > Thanks > Martin > > $ git push > Enumerating objects: 23, done. > Counting objects: 100% (23/23), done. > Delta compression using up to 16 threads > Compressing objects: 100% (12/12), done. > Writing objects: 100% (12/12), 2.41 KiB | 2.41 MiB/s, done. > Total 12 (delta 11), reused 0 (delta 0) > remote: *** ChangeLog format failed: > remote: ERR: file not changed in a patch:"gcc/cp/cp-tree.c" > remote: ERR: changed file not mentioned in a > ChangeLog:"gcc/cp/tree.c" > remote: > remote: Please see: > https://gcc.gnu.org/codingconventions.html#ChangeLogs > remote: > remote: error: hook declined to update refs/heads/master > To git+ssh://gcc.gnu.org/git/gcc.git > ! [remote rejected] master -> master (hook declined) > error: failed to push some refs to > 'git+ssh://mse...@gcc.gnu.org/git/gcc.git' > > $ head gcc/cp/ChangeLog > 2020-05-18 Martin Sebor <mse...@redhat.com> > > PR c++/94923 > * call.c ((maybe_warn_class_memaccess): Use > is_byte_access_type. > * cp-tree.h (is_dummy_object): Return bool. > (is_byte_access_type): Declare new function. > * cp-tree.c (is_dummy_object): Return bool. > (is_byte_access_type): Define new function. > > 2020-05-19 Patrick Palka <ppa...@redhat.com> >
