Jakub Jelinek <ja...@redhat.com> writes:
> While working on Fedora gcc 9 rpm, I've noticed a couple of messages: > *** WARNING: > ./usr/src/debug/gcc-9.0.0-0.1.fc29.x86_64/libphobos/libdruntime/core/sys/posix/sys/ioccom.d > is executable but has empty or no shebang, > *** WARNING: > ./usr/src/debug/gcc-9.0.0-0.1.fc29.x86_64/libphobos/libdruntime/core/sys/posix/sys/ttycom.d > is executable but has empty or no shebang, > *** WARNING: > ./usr/src/debug/gcc-9.0.0-0.1.fc29.x86_64/gcc/ada/set_targ.ads is > executable but has empty or no shebang, removing executable bit > *** WARNING: > ./usr/src/debug/gcc-9.0.0-0.1.fc29.x86_64/gcc/ada/set_targ.adb is > executable but has empty or no shebang, removing executable bit > *** WARNING: > ./usr/src/debug/gcc-9.0.0-0.1.fc29.x86_64/libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc > is executable but has empty or no shebang, removing executable bit > > None of these files look like executable, any objections against (found > through > find [^o]* -type f -a -executable | xargs grep -L '^#!' > and removed from the list some ELF/Mach-O executables in the libgo (which > maybe shouldn't be executable anyway, we don't want people to run it when > they don't really know what it contains))? Do the libgo and/or > libphobos changes need to go through upstream first? The libgo changes don't need to go through upstream. Oddly the container/list files are not marked executable in upstream anyhow. I don't know why they are marked executable in the GCC sources. Thanks. Ian > I've checked libsanitizer upstream and sanitizer_common_interceptors_ioctl.inc > isn't executable there. > > svn propdel svn:executable \ > contrib/reghunt/examples/reg-watch.awk \ > gcc/testsuite/gcc.target/csky/fnmul-1.c \ > gcc/testsuite/gcc.target/csky/fnmul-3.c \ > gcc/testsuite/gcc.target/csky/fnmul-2.c \ > gcc/testsuite/gcc.target/csky/fnmul-4.c \ > gcc/testsuite/gcc.target/arc/loop-1.c \ > gcc/testsuite/gcc.target/arc/sdata-5.c \ > gcc/testsuite/gcc.target/arc/tdelegitimize_addr.c \ > gcc/testsuite/gcc.target/arc/pr9001195952.c \ > gcc/testsuite/gcc.target/arc/bitfield.c \ > gcc/testsuite/gcc.target/arc/tumaddsidi4.c \ > gcc/testsuite/gcc.dg/format/sys_format.c \ > gcc/ada/set_targ.ads \ > gcc/ada/set_targ.adb \ > libgo/go/container/list/list.go \ > libgo/go/container/list/list_test.go \ > libphobos/libdruntime/core/sys/posix/sys/ioccom.d \ > libphobos/libdruntime/core/sys/posix/sys/ttycom.d \ > libsanitizer/sanitizer_common/sanitizer_common_interceptors_ioctl.inc > > Jakub
