On 11/21/18 4:47 AM, Andi Kleen wrote: > Indu Bhagat <indu.bha...@oracle.com> writes: > >> Proposal to add diagnostics to know which functions were not run in the >> training run in FDO. > > Don't you think the warning will be very noisy? I assume most programs > have a lot of cold error handling functions etc. that are never executed > in a normal execution. > > Like how does it look like for a gcc build for example?
I guess like this: https://users.suse.com/~mliska/lcov/ Indu, have you thought about using gcov/lcov rather than inventing a new warning (or opt info)? Can you please define exactly your use case? Martin > > I suspect it would need some heuristics to cut it down at least, like if > the function ends with exit (perhaps propagated through the call tree) > it's not flagged. Or if there is warning for a function don't warn > about callees that are not called from somewhere else. > > -Andi >
