Jeff Law <l...@redhat.com> writes: > On 08/20/2015 11:28 AM, Claudiu Zissulescu wrote: >> Hi Jeff, >> >> In the gencodes.c:89, it explicitly decrements by one the return >> value of get_num_insn_codes(). While for the get_num_insn_codes is >> stated this: >> >> /* Return the number of possible INSN_CODEs. Only meaningful once the >> whole file has been processed. */ >> >> I can provide an example for the ARC port where it crashes due to >> LAST_INSN_CODE issue. Probably it can be reproduced with other more >> popular port like ARM. > Passing along a test, even for the ARC is useful. > > This is something Richard recently changed, it's probably just an > oversight on his part.
Yeah :-( That's a mightly confusing name. I'm going to try changing it to NUM_INSN_CODES and make it a const unsigned int (rather than keeping it as part of the enum). Thanks, Richard
