On 01/27/2015 10:04 AM, Richard Biener wrote: > On Tue, 27 Jan 2015, Andreas Krebbel wrote: > >> Hi, >> >> I would like to apply the following patch: >> >> [PATCH] S/390: -mhotpatch v2 >> https://gcc.gnu.org/ml/gcc-patches/2015-01/msg02370.html >> >> It is a backend only change to our existing -mhotpatch feature >> requested by the Linux kernel guys for the ftrace implementation: >> https://lkml.org/lkml/2015/1/26/320 >> >> They need it in an upstream GCC asap. If we don't get it into 5.0 we >> probably would need to commit it onto 5.1 branch right after the >> release. I would rather try to avoid this since it would make the >> hotpatch feature incompatible between 5.0 and 5.1. >> >> Ok to do it now? > > Ok. It needs an entry in changes.html.
Ok. > Do you plan to backport this change? Yes we already have backports for 4.9 and 4.8 (which itself was a backport from 4.9). Should we try to bring the 4.9 backport upstream as well? > Did you consider using an alternate option name instead of changing > it in an incompatible way? Yes. But given that: - the hotpatch feature was introduced recently (with 4.9) we do not expect any users so far - if somebody really used the feature he will get an error message at compile-time, so the fix is easy - the kernel implementation is able to distingiush the different hotpatch versions already and it is the only user we know of > I realize SUSE will need to backport this > thus any user will need to do functional testing to see whether his > compiler implements the new or old semantics? We will provide you with a backported version. Bye, -Andreas- > > Thanks, > Richard. >
