On Thu, Sep 11, 2014 at 11:24:08PM +0200, Bernhard Reutner-Fischer wrote:
> On 11 September 2014 20:19:31 Jakub Jelinek <ja...@redhat.com> wrote:
>
> >On Thu, Sep 11, 2014 at 07:26:37PM +0200, Jakub Jelinek wrote:
> >> right now. The patch below intends to serialize the content of the
> >> problematic *.exp tests (the first runtest to reach one of those will
> >> simply
> >> run all the tests from that *.exp file, others will skip it).
> >
> >Forgotten patch below. BTW, something will probably need to be done about
> >acats too, either similar approach or just splitting the chapters into
> >little more jobs, because otherwise in make -C check -j48 acats dominated
> >the testing time for me.
>
>
> + if [ -n "$(check_p_subno)" \
> + -a -n "$$GCC_RUNTEST_PARALLELIZE_DIR" \
> + -a -f $(TESTSUITEDIR)/$(check_p_tool)-parallel/finished ]; then \
>
> test(1) -a and -o are obsolescent, please chain [] && [] instead.
That is news to me, but given the amount of test -a/-o uses e.g. in
gcc/configure and hundreds of places, I'd say what we care is what is more
portable to old shells.
Jakub
