On Tue, Oct 1, 2013 at 8:00 AM, Oleg Smolsky <oleg.smol...@riverbed.com> wrote:
> Hey all, hey Paul, it looks like the code branches/google/gcc-4_8 does not
> compile any more:
It sure does still build for us.
> I've attached the fill log.
How was this GCC configured?
> As a guess, it may be due to the following commit.
>
> r202927 | ppluzhnikov | 2013-09-25 15:12:11 -0700 (Wed, 25 Sep 2013) | 11
> lines
Yes, that's where snprintf_lite.cc was added to google/gcc-4_8.
Looking at the failure, the ambiguity comes from:
int std::__int_to_char(_CharT*, _ValueT, const _CharT*,
std::__7::ios_base::fmtflags, bool)
int std::__7::__int_to_char(_CharT*, _ValueT, const _CharT*,
std::__7::ios_base::fmtflags, bool)
Both [with _CharT = char; _ValueT = long long unsigned int;
std::__7::ios_base::fmtflags = std::__7::_Ios_Fmtflags]
I am guessing that attached patch should fix it for you.
The same problem likely exists on trunk, so please do tell how to configure
GCC in order to reproduce it.
Paolo, does attached patch look correct for trunk?
Thanks,
--
Paul Pluzhnikov
Index: libstdc++-v3/src/c++11/snprintf_lite.cc
===================================================================
--- libstdc++-v3/src/c++11/snprintf_lite.cc (revision 202927)
+++ libstdc++-v3/src/c++11/snprintf_lite.cc (working copy)
@@ -28,6 +28,7 @@
#include <bits/locale_facets.h>
namespace std {
+_GLIBCXX_BEGIN_NAMESPACE_VERSION
template<typename _CharT, typename _ValueT>
int
__int_to_char(_CharT* __bufend, _ValueT __v, const _CharT* __lit,
