On Thu, Apr 04, 2013 at 01:41:30PM -0400, Jason Merrill wrote: > On 04/04/2013 11:48 AM, Senthil Kumar Selvaraj wrote: > >+Common Var(dwarf_version, 4) Negative(gdwarf-) > > I don't think you need to mention the variable on this line; it's > already there and statically initialized for gdwarf-. > Yeah, you're right. I was originally attempting to use "value" directly, and that of course, didn't work as it was set to 1. Sorry, I should have been more careful.
> >I wasn't able to get this done in a clean way. To make the gdwarf option > >handling code detect this error, the only I found was to make it > >JoinedOrMissing, and then raise the error if there was an argument > >provided. > > That sounds clean enough to me. > Ok, I thought it was odd to specify that gdwarf has an optional argument in the opt file, only to reject it outright when processing it. Will send another patch tomorrow. Regards Senthil
