On Fri, Dec 21, 2012 at 05:06:46PM +0100, Richard Günther wrote:
> Jack Howarth <howa...@bromo.med.uc.edu> wrote:
>
> >Tobi,
> >Can you update the isl and cloog tarballs in the gcc infrastructure
> >directory
> >to the new isl 0.11.1 and cloog 0.18.0 releases from...
> >
> >ftp://ftp.linux.student.kuleuven.be/pub/people/skimo/isl//isl-0.11.1.tar.bz2
> >http://www.bastoul.net/cloog/pages/download/cloog-0.18.0.tar.gz
> >
> >It looks like config/isl.m4 needs to be modified to understand MAJOR,
> >MINOR, REVISION
> >for the isl 0.11.1 version numbering.
>
> I don't think we need to require the new versions as the old ones work just
> fine. The ils check also works with 0.11 for me.
>
> Richard.
Richard,
The main issue is that the test in configure is brain-dead and demands an
explicit version.
This is a problem since llvm 3.2 will now ship with polly support that requires
the newer version
and this polly can be called from within dragonegg. So by refusing to
synchronize to the newer
cloog/isl releases (which cause no regressions in the graphite testsuite), we
are forcing
distributions to patch FSF gcc 4.8 to work around this. Refusing to update
cloog/isl seems like
being unnecessarily obstinate on this.
Jack
>
> >Index: configure.ac
> >===================================================================
> >--- configure.ac (revision 194661)
> >+++ configure.ac (working copy)
> >@@ -1607,7 +1607,7 @@ if test "x$with_isl" != "xno" &&
> > dnl with user input.
> > ISL_INIT_FLAGS
> > dnl The minimal version of ISL required for Graphite.
> >- ISL_CHECK_VERSION(0,10)
> >+ ISL_CHECK_VERSION(0,11,1)
> > dnl Only execute fail-action, if ISL has been requested.
> > ISL_IF_FAILED([
> >AC_MSG_ERROR([Unable to find a usable ISL. See config.log for
> >details.])])
> >@@ -1621,7 +1621,7 @@ if test "x$with_isl" != "xno" &&
> > dnl
> > dnl If we use CLooG-Legacy, the provided version information is
> > dnl ignored.
> >- CLOOG_CHECK_VERSION(0,17,0)
> >+ CLOOG_CHECK_VERSION(0,18,0)
> >
> > dnl Only execute fail-action, if CLooG has been requested.
> > CLOOG_IF_FAILED([
> >Index: config/isl.m4
> >===================================================================
> >--- config/isl.m4 (revision 194661)
> >+++ config/isl.m4 (working copy)
> >@@ -89,13 +89,13 @@ AC_DEFUN([ISL_REQUESTED],
> > ]
> > )
> >
> >-# _ISL_CHECK_CT_PROG(MAJOR, MINOR)
> >+# _ISL_CHECK_CT_PROG(MAJOR, MINOR, REVISION)
> > # --------------------------------------------
> > # Helper for verifying ISL compile time version.
> > m4_define([_ISL_CHECK_CT_PROG],[AC_LANG_PROGRAM(
> > [#include <isl/version.h>
> > #include <string.h>],
> >- [if (strncmp (isl_version (), "isl-$1.$2", strlen ("isl-$1.$2")) !=
> >0)
> >+ [if (strncmp (isl_version (), "isl-$1.$2.$3", strlen
> >("isl-$1.$2.$3")) != 0)
> > return 1;
> > ])])
> >
> >@@ -115,9 +115,9 @@ AC_DEFUN([ISL_CHECK_VERSION],
> > LIBS="${_isl_saved_LIBS} -lisl"
> > echo $CFLAGS
> >
> >- AC_CACHE_CHECK([for version $1.$2 of ISL],
> >+ AC_CACHE_CHECK([for version $1.$2.$3 of ISL],
> > [gcc_cv_isl],
> >- [AC_RUN_IFELSE([_ISL_CHECK_CT_PROG($1,$2)],
> >+ [AC_RUN_IFELSE([_ISL_CHECK_CT_PROG($1,$2,$3)],
> > [gcc_cv_isl=yes],
> > [gcc_cv_isl=no],
> > [gcc_cv_isl=yes])])
> >
> >seems to work fine. Thanks in advance.
> > Jack
>
>
> --
> Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
