On Thu, Nov 1, 2012 at 9:44 AM, Diego Novillo <dnovi...@google.com> wrote: > On Thu, Nov 1, 2012 at 12:40 PM, Sharad Singhai <sing...@google.com> wrote: >> I found the problem and the following patch fixes it. The issue with >> my testing was that I was only looking at 'FAIL' lines but forgot to >> tally the 'UNRESOLVED' test cases, the real symptoms of my test >> problems. In any case, I am rerunning the whole testsuite just to be >> sure. >> >> Assuming tests pass, is it okay to commit the following? >> >> Thanks, >> Sharad >> >> 2012-11-01 Sharad Singhai <sing...@google.com> >> >> PR other/55164 >> * dumpfile.h (struct dump_file_info): Fix order of flags. > > OK (remember to insert a tab at the start of each ChangeLog line).
Fixed tab chars. (they were really there, but gmail ate them! :)) Retested and found all my 'UNRESOLVED' problems were gone. Hence committed the fix as r193064. Thanks, Sharad > > Diego.