Quoting Ian Lance Taylor <i...@google.com>:
On Tue, Sep 11, 2012 at 3:18 PM, Lawrence Crowl <cr...@googlers.com> wrote:
The contrib/config-list.mk tool appears to be suffering from bitrot.
The make failures for a limited subset of configurations consisted
exclusively of:
cc1: warnings being treated as errors
../../../../gcc/fixincludes/server.c: In function 'server_setup':
../../../../gcc/fixincludes/server.c:195: error: ignoring return value
of 'getcwd', declared with attribute warn_unused_result
The warning is correct. It is not clear what one should do upon
testing the return value, as server_setup does not signal errors.
Suggestions?
Do we consider contrib/config-list.mk dead?
I don't know whether contrib/config-list.mk is dead or not.
I certainly hope not.
But I do
know that you will only get that error on Debian or Ubuntu systems,
which by default pass some rather aggressive warning options.
So does that mean that bootstrap is broken there too?
It would be fine to have the program crash if getcwd somehow fails.
There is nothing useful that it can do in that unlikely case.
However, less desirable would be if the program silently continues and
makes the user think everything is fine when it isn't. Maybe even alter
some files it isn't supposed to alter in the process.
As buff is an automatic variable, it is likely it contains somethng that can
be interpreted as a string.
So calling abort / exit (1) or something similar when things go wrong would
make sense.
