On Wed, Jun 6, 2012 at 10:07 PM, Iain Sandoe <i...@codesourcery.com> wrote:
> Hi Steven,
> The attached patch survives normal and lto bootstrap on i686-darwin9 and 
> x86_64-darwin10.
> No regressions for ObjC or Obj-C++.
> Otherwise, lightly tested, but appears to solve PR 48109 on the way.
>
> changes:
>
>  o [minor] typo fixes and some changes to the comments, minor adjustments to 
> make the asm indents match with other code.
>
>  o  I moved the functions to config/darwin-c.c (I suspect that's what you 
> originally intended, from the comments).
>
>  o I made two (c-family) target hooks instead of generating new target macros 
> -
>     side benefits of this are:
>      (i) that we can also remove tm.h from objc-next-runtime-abi-01.c
>      (ii) we don't end up with dead code pathways on non-darwin builds.
>      (iii) the actual implementation of the defs/refs is now private to 
> Darwin.

Looks a lot prettier to me :-)

> if you think this good to go - given that Mike has already commented, then I 
> guess we should move it to Patches for review.

Sounds like a plan.

Ciao!
Steven

Reply via email to