Nathan Froyd <froy...@codesourcery.com> writes: > On Wed, Mar 02, 2011 at 07:14:53AM -0800, Ian Lance Taylor wrote: >> This patch should at least cause genrecog to crash for you rather than >> generating bogus output. I've verified that this patch bootstraps on >> x86_64 and makes no difference in the generated insn-recog.c. Can you >> see whether this gives you a crash? Any opinion on whether I should >> commit this to mainline? >> >> + gcc_assert (i < 26); >> + gcc_assert (j < 26); >> + gcc_assert (j - 1 < 26); > > Is it worthwhile pulling out the 26 into a #define somewhere? (Maybe > not, as there are pre-existing 26-esque constants elsewhere?)
Sure, I can do that if other maintainers think the patch in general is a good idea. I think the number 26 is pretty obvious, though, in context. I don't think giving it a name will actually make it clearer. Ian
