On 29 January 2011 20:43, Arnaud Lacombe wrote:
> Hi,
>
> On Fri, Jan 28, 2011 at 4:32 AM, Jonathan Wakely <jwakely....@gmail.com> 
> wrote:
>> On 28 January 2011 01:11, Joseph S. Myers wrote:
>>>
>>> * a.out NetBSD (arm*-*-netbsd* not matching arm*-*-netbsdelf*,
>>> i[34567]86-*-netbsd* not matching i[34567]86-*-netbsdelf*, vax-*-netbsd*
>>> not matching vax-*-netbsdelf*).
>>
>> This implies some x86 targets are expected to work, but NetBSD-current
>> can't build recent versions of gcc on x86 at all, due to
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47147
>>
>> My patch is still waiting for review:
>> http://gcc.gnu.org/ml/gcc-patches/2011-01/msg01280.html
>>
> Last time I checked, this solution kept other arch broken. The best
> way might be to cleanly exclude `stddef.h' from USER_H, as I tried to
> do in [0], but I've been a bit overzealous. The following should do
> the job (completely untested):
>
> diff --git a/gcc/config/t-netbsd b/gcc/config/t-netbsd
> index 34949e1..fa8744d 100644
> --- a/gcc/config/t-netbsd
> +++ b/gcc/config/t-netbsd
> @@ -1,2 +1,6 @@
>  # Always build crtstuff with PIC.
>  CRTSTUFF_T_CFLAGS_S = $(CRTSTUFF_T_CFLAGS) -fPIC
> +
> +USER_H = $(srcdir)/ginclude/float.h \
> +         $(srcdir)/ginclude/iso646.h \
> +         $(srcdir)/ginclude/stdarg.h \
> +         $(srcdir)/ginclude/stdbool.h \
> +         $(srcdir)/ginclude/varargs.h \
> +         $(srcdir)/ginclude/stdfix.h
>
> unfortunately (or not), I no longer have a NetBSD box to test this with.
>
>  - Arnaud
>
> [0]: http://mail-index.netbsd.org/tech-toolchain/2010/12/09/msg001420.html

Ah, I did look in the NetBSD cvs repository and the other arches I
looked at just used _ANSI_H_, I obviously didn't check the ones you
identified.

We only have a bug report concerning x86, and I didn't want to make
such a large change. Presumably GCC's stddef.h is/was needed for some
older NetBSD versions, and I don't have resources or time to find that
out or test a patch.

I've committed my patch (approved by Ian) so maybe someone else will
do a more complete fix later.

Jonathan

Reply via email to