I think gcc-cvs mail list should set reply address to gcc@gcc.gnu.org
instead of gcc-...@gcc.gnu.org.
---------- Forwarded message ----------
From: Dongsheng Song <dongsheng.s...@gmail.com>
Date: Sat, Jan 1, 2011 at 11:29
Subject: Re: r168382 - in /trunk/libstdc++-v3: ChangeLog Mak...
To: b...@gcc.gnu.org
Cc: gcc-...@gcc.gnu.org
Hi Benjamin,
Your commit have 2 drawbacks:
1. insufficient docbook xsl path checker (trunk/libstdc++-v3/configure.ac)
# Check for docbook
AC_CHECK_PROG([XSLTPROC], xsltproc, yes, no)
AC_CHECK_PROG([XMLLINT], xmllint, yes, no)
AC_CHECK_FILE([/usr/share/sgml/docbook/xsl-ns-stylesheets/VERSION],
[glibcxx_stylesheets=yes], [glibcxx_stylesheets=no])
For Debian, here is the correct path:
-rw-r--r-- 1 root root 4510 Jul 22 2009
/usr/share/xml/docbook/stylesheet/docbook-xsl-ns/VERSION
-rw-r--r-- 1 root root 4504 Jul 21 2009
/usr/share/xml/docbook/stylesheet/docbook-xsl/VERSION
2. break cross compiling (trunk/libstdc++-v3/configure)
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for
/usr/share/sgml/docbook/xsl-ns-stylesheets/VERSION" >&5
$as_echo_n "checking for
/usr/share/sgml/docbook/xsl-ns-stylesheets/VERSION... " >&6; }
if test "${ac_cv_file__usr_share_sgml_docbook_xsl_ns_stylesheets_VERSION+set}"
= set; then :
$as_echo_n "(cached) " >&6
else
test "$cross_compiling" = yes &&
as_fn_error "cannot check for file existence when cross compiling" "$LINENO" 5
if test -r "/usr/share/sgml/docbook/xsl-ns-stylesheets/VERSION"; then
ac_cv_file__usr_share_sgml_docbook_xsl_ns_stylesheets_VERSION=yes
else
ac_cv_file__usr_share_sgml_docbook_xsl_ns_stylesheets_VERSION=no
fi
fi
After as_fn_error, my cross compiling failed without use hard code path.
--
Dongsheng
On Sat, Jan 1, 2011 at 06:20, <b...@gcc.gnu.org> wrote:
> Author: bkoz
> Date: Fri Dec 31 22:20:22 2010
> New Revision: 168382
>
> URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168382
> Log:
> 2010-12-31 Benjamin Kosnik <b...@redhat.com>
>
> * scripts/run_doxygen: Allow doxygen 1.7.1 again.
>
> * doc/xml/manual/build_hacking.xml: Update.
> * doc/xml/images/confdeps.dot: Same.
> * doc/xml/images/confdeps.png: Same.
>
> * configure.ac: Define BUILD_INFO, BUILD_XML, BUILD_HTML,
> BUILD_MAN, BUILD_PDF, BUILD_EPUB conditionally.
> * Makefile.am (xml, html, pdf, man, info, pd, dvi, epub): Define,
> and install rules.
> * doc/Makefile.am: Same. Add stamp rules.
> (doc-epub-docbook): Add.
> (stamp-xml-single-docbook): Make set too.
> * configure: Regenerate.
> * Makefile.in: Same.
> * doc/Makefile.in: Same.
> * include/Makefile.in: Same.
> * libsupc++/Makefile.in: Same.
> * po/Makefile.in: Same.
> * python/Makefile.in: Same.
> * src/Makefile.in: Same.
> * testsuite/Makefile.in: Same.
> * aclocal.m4: Same.
>
> 2010-12-31 Benjamin Kosnik <b...@redhat.com>
>
> * doc/doxygen/user.cfg.in: Disable PDF_HYPERLINKS.
>
>
> Modified:
> trunk/libstdc++-v3/ChangeLog
> trunk/libstdc++-v3/Makefile.am
> trunk/libstdc++-v3/Makefile.in
> trunk/libstdc++-v3/aclocal.m4
> trunk/libstdc++-v3/configure
> trunk/libstdc++-v3/configure.ac
> trunk/libstdc++-v3/doc/Makefile.am
> trunk/libstdc++-v3/doc/Makefile.in
> trunk/libstdc++-v3/doc/doxygen/user.cfg.in
> trunk/libstdc++-v3/doc/xml/images/confdeps.dot
> trunk/libstdc++-v3/doc/xml/manual/build_hacking.xml
> trunk/libstdc++-v3/include/Makefile.in
> trunk/libstdc++-v3/libsupc++/Makefile.in
> trunk/libstdc++-v3/po/Makefile.in
> trunk/libstdc++-v3/python/Makefile.in
> trunk/libstdc++-v3/scripts/run_doxygen
> trunk/libstdc++-v3/src/Makefile.in
> trunk/libstdc++-v3/testsuite/Makefile.in
>
>
