On Tue, Oct 5, 2010 at 8:57 AM, Richard Henderson <r...@redhat.com> wrote: > On 10/04/2010 04:24 PM, H.J. Lu wrote: >> As I remembered, -mforce-drap exposed issues with register allocator. >> ix86_force_drap is only referenced in one place in i386.c. I'd like to keep >> it. I don't see why it can't be moved to generic. It may expose problems >> for other targets. > > I doubt very much if any other target will ever implement > stack re-alignment like x86 does. The patch I posted is > good enough to handle any arbitrary user variable alignment. > The only thing it doesn't handle is alignment for spill > slots. Only x86 requires that. >
Gcc fails to properly pass aligned variables on stack: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44948 A patch is posted at http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01669.html How does your proposal pass aligned parameters on stack for other targets? -- H.J.
