"Naveen H. S" <[email protected]> wrote:
>>> you can free to propose a complete and regtested patch for SH
>>> assembly soft fp against trunk.
>
> Please find attached the ported soft float patch "sh_softfloat.patch".
> The original patch was posted at the following link by Joern RENNECKE.
> http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00614.html
Your patches are for 4.5.0 and sh_softfloat.patch can't be
applicable for trunk cleanly. Please provide patches against
svn trunk and the ChangeLog entries for them.
Here is an incomplete list of comments for sh_softfloat.patch:
*target*:
New macro TARGET_MATCH_ADJUST requires a doc patch.
reload.c:
config/sh/lib1funcs.asm:
config/sh/lib1funcs.h:
Copyright years of these files should be updated.
All copyright of IEEE-754/* files should be GPLv3 with Runtime
library exception instead of v2 and 2010 should be added to
their copyright years.
Please see the one used in sh/lib1funcs.asm for example.
config/sh/sh.c:
>+/* Saved operands from the last compare to use when we generate an scc
>+ or bcc insn. */
>+
>+rtx sh_compare_op0;
>+rtx sh_compare_op1;
It looks that sh_compare_op0 snd sh_compare_op1 are set but
not used.
>+ REG_NOTES (last) = gen_rtx_EXPR_LIST (REG_EQUAL, equiv, REG_NOTES (last));
Use add_reg_note here. Several other similar cases.
> Please find attached the patch ""sh_softfp.patch" which implements basic
> support of soft-fp for SH target. There were no regressions found with
> the patch. Please let us know if there should be any further improvements
> required for complete soft-fp support.
sh_softfp.patch looks basically OK to me, though I'm curious
with numbers for fp-bit.c/softfp/softfloat. Could you show us
some real speed&size numbers?
Regards,
kaz
