On Wed, Apr 21, 2010 at 07:48:36PM +0200, Paolo Bonzini wrote: > On 04/21/2010 07:42 PM, Jack Howarth wrote: >> However in the past when I submitted patches for areas outside >> of the darwin specific source files, they were rejected*if* they >> made the code too darwin-centric. > > Well, in this case I gave you a suggestion, so it was implicit that I'd > have approved that patch, no? > >> In this case, I am attempting >> to deal with the general case if objdump not being present. >> Don't other hosts (AIX?) lack objdump in their default configuration? >> I explicitly avoided using darwin-specific tools to implement >> the fall-back when objdump is absent so that other hosts lacking >> objdump could benefit as well. > > I'm not sure if "nm -g" would work under Linux, since > > $ nm -g /usr/lib64/libsqlite3.so > nm: /usr/lib64/libsqlite3.so: no symbols > > $ objdump -T /usr/lib64/libsqlite3.so|head -5 > > /usr/lib64/libsqlite3.so: file format elf64-x86-64 > > DYNAMIC SYMBOL TABLE: > 00000037aca081b8 l d .init 0000000000000000 .init > > > So I prefer to have this only on Darwin for now.
But it should never trigger under Linux since you always have binutils and therefore objdump, right? > > Paolo
