Hi, On Wed, 25 Nov 2009, Jeff Law wrote:
> On 11/25/09 09:51, Richard Kenner wrote: > > > Can someone please remove this revision from the subversion database > > > on the server and fix things up? If that's not possible at least > > > the revision should be reverted. > > > > > Why the latter? I agree with the problems this can cause, but if they > > can't be fixed by removing it from the database, why revert it? All things > > being equal, trailing blanks in fact aren't a good idea. > > > I agree with Kenner here. We've encouraged removal of trailing > whitespace in the past Not as bulk changes that don't do anything else, rather only as part of changes that touch the relevant parts anyway. > and I don't why this should be any different. It does make things > marginally harder when dealing with branches, And local patches. Basically _no_ patch will apply anymore as HJ changed every single file. That's not something marginally harder, it's terrible pointless thankless work created by a single 500 KB svn commit. svn blame will now also point to HJ most of the time, wonderful! > but the right way to deal with that problem is to avoid trailing > whitespace in the source tree to begin with. In an ideal world, yes. But it's not a clever idea to burn down the house just because the walls have some dots nobody cares about. Ciao, Michael.
