On Mon, 21 Sep 2009, Jon Beniston wrote:
> Probably best to review an updated patch which is attached, which implements
> all the 4.5 changes.
The target-side files now need to use the new GPLv3 exception, not the old
GPLv3 one.
> * config/lm32/xm-lm32.h: New file.
As I said before, this file is not needed. It looks like you've removed
it; you need to update the ChangeLog entries.
> * gcc.dg/builtins-config.h: lm32 doesn't have the entire C99
> runtime.
Likewise.
> +/* Abort after printing out a specific insn. */
> +static void
> +abort_with_insn (rtx insn, const char *reason)
> +{
> + error (reason);
> + debug_rtx (insn);
> + abort ();
> +}
Use the GCC-standard fatal_insn instead of inventing your own
error-reporting functions (if you invent your own you need to take care
about i18n, which you didn't here).
There are several abort () calls elsewhere in the back end that should use
gcc_unreachable () (or maybe gcc_assert in some cases).
I have not checked whether my previous comments are addressed.
--
Joseph S. Myers
jos...@codesourcery.com
