Joseph S. Myers wrote:
On Tue, 9 Jun 2009, Daniel Berlin wrote:
be, most things support it, and there are some cool possibilities,
like gerrit (http://code.google.com/p/gerrit/). It is precisely built
I think a critical feature of any fancy code review system (or of how it
is configured for GCC) used for a significant amount of GCC review is that
all the patches and reviews are automatically sent to gcc-patches in plain
text so that they get archived in the static list archives and can
continue to be referred to that way, grepped, etc., after the next N
transitions. Email replies to patch submissions should also continue to
work smoothly.
Yes, Daniel just mentioned a possibility. It is good to consider
possible developments even if for now you're just keeping the old workflow.
gerrit was developed at Google, but git's own development (and Linux's)
proceeds only on mailing lists, and for this reason git has a command like
git send-email --cc jos...@codesourcery.com master..HEAD
to submit a private branch all at once to gcc-patches@ and CC you. :-)
It is true however that currently we are not encouraging outsiders to
contribute, because old timers work on mostly large patches (or large
sequences of patches) that reviewers know about. For the same reason,
it is easier for small patches to fall through the cracks than large ones.
Paolo
