2009/4/23 Ben Elliston <b...@au1.ibm.com>:
> Hi HJ
>
> According to svn annotate, it was you who authored the new 'offset
> outside bounds of constant string warning' warning in GCC (well, I think
> so, anyway). The compiler now complains about some code in the C++
> demangler:
>
> /home/bje/source/gcc-trunk/libiberty/cplus-dem.c:2651: warning: offset ‘3’
> outside bounds of constant string
>
> I tracked this down to the definition of strspn used on my Linux system:
>
> # define strspn(s, accept) \
> __extension__ \
> ({ char __a0, __a1, __a2; \
> (__builtin_constant_p (accept) && __string2_1bptr_p (accept) \
> ? ((__builtin_constant_p (s) && __string2_1bptr_p (s)) \
> ? __builtin_strspn (s, accept) \
> : ((__a0 = ((__const char *) (accept))[0], __a0 == '\0') \
> ? ((void) (s), 0) \
> : ((__a1 = ((__const char *) (accept))[1], __a1 == '\0') \
> ? __strspn_c1 (s, __a0) \
> : ((__a2 = ((__const char *) (accept))[2], __a2 == '\0') \
> ? __strspn_c2 (s, __a0, __a1) \
> : (((__const char *) (accept))[3] == '\0' \
> ? __strspn_c3 (s, __a0, __a1, __a2) \
> : __builtin_strspn (s, accept)))))) \
> : __builtin_strspn (s, accept)); })
>
> Is this something you can fix?
>
I authored the patch, HJ just committed it. I cannot think any trivial
way to fix this and I don't have much time to investigate. The PR is
already reopened, so I think the patch should be reverted. Probably we
warn too early now but the above testcase seems specially difficult to
handle.
With the revert, it would useful to add one of the failing testcases
to the testsuite, to avoid repeating this situation.
Cheers,
Manuel.
