In the current compiler, it seems very likely that every call to decl_constant_value_for_broken_optimization can simply be removed. The constant propagation passes should implement the optimization.
What about format checking for constant arrays? :-( That's the testcase that Joseph wrote for the patch that introduced the function.
Paolo
