Re: Bootstrap is broken on x86_64, comparison between signed and unsigned in optabs.c

[Sandra Loosemore]

Uros Bizjak wrote:

Uros Bizjak wrote:

gcc Revision: 126372, bootstrap from clean directory breaks with:

/home/uros/gcc-build/./prev-gcc/xgcc -B/home/uros/gcc-build/./prev-gcc/ -B/usr/local/x86_64-unknown-linux-gnu/bin/ -c -g -O2 -DIN_GCC -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc-svn/trunk/gcc -I../../gcc-svn/trunk/gcc/. -I../../gcc-svn/trunk/gcc/../include -I../../gcc-svn/trunk/gcc/../libcpp/include -I../../gcc-svn/trunk/gcc/../libdecnumber -I../../gcc-svn/trunk/gcc/../libdecnumber/bid -I../libdecnumber ../../gcc-svn/trunk/gcc/optabs.c -o optabs.o

cc1: warnings being treated as errors
../../gcc-svn/trunk/gcc/optabs.c: In function ‘expand_binop’:

../../gcc-svn/trunk/gcc/optabs.c:1463: error: comparison between signed and unsigned

gmake[3]: *** [optabs.o] Error 1
gmake[3]: *** Waiting for unfinished jobs....
rm fsf-funding.pod gcov.pod gfdl.pod cpp.pod gpl.pod gfortran.pod gcc.pod
gmake[3]: Leaving directory `/home/uros/gcc-build/gcc'
gmake[2]: *** [all-stage2-gcc] Error 2
gmake[2]: Leaving directory `/home/uros/gcc-build'
gmake[1]: *** [stage2-bubble] Error 2
gmake[1]: Leaving directory `/home/uros/gcc-build'
gmake: *** [all] Error 2

It must be very recent change.

Broken by:

2007-07-05 Sandra Loosemore <[EMAIL PROTECTED]>
David Ung <[EMAIL PROTECTED]>

Add support for SmartMIPS ASE.

* optabs.c (expand_binop_directly): New, broken out from...
(expand_binop): Here. Make it try rotating in the other
direction even when the second operand isn't constant.
...

Ooops, sorry!  Fixed thusly, and committed as obvious.

-Sandra



2007-07-05  Sandra Loosemore  <[EMAIL PROTECTED]>

	gcc/
	* optabs.c (expand_binop_directly): Fix signed/unsigned comparison.

Index: gcc/optabs.c
===================================================================
*** gcc/optabs.c	(revision 126381)
--- gcc/optabs.c	(working copy)
*************** expand_binop (enum machine_mode mode, op
*** 1456,1462 ****
      {
        optab otheroptab = (binoptab == rotl_optab ? rotr_optab : rotl_optab);
        rtx newop1;
!       int bits = GET_MODE_BITSIZE (mode);
  
        if (GET_CODE (op1) == CONST_INT)
  	newop1 = GEN_INT (bits - INTVAL (op1));
--- 1456,1462 ----
      {
        optab otheroptab = (binoptab == rotl_optab ? rotr_optab : rotl_optab);
        rtx newop1;
!       unsigned int bits = GET_MODE_BITSIZE (mode);
  
        if (GET_CODE (op1) == CONST_INT)
  	newop1 = GEN_INT (bits - INTVAL (op1));