Dave Korn wrote:
> On 04 July 2007 19:25, Alexandre Oliva wrote:
>
>
>> Actually, how about replacing the three variables with a single
>> tri-state variable that indicates the progress into reload:
>>
>> enum { BEFORE_RELOAD = -1, DURING_RELOAD = 0, AFTER_RELOAD = 1 }
>> reload_status;
>>
>> #define BEFORE_RELOAD_P() (reload_status < DURING_RELOAD)
>> #define DURING_RELOAD_P() (reload_status == DURING_RELOAD)
>> #define AFTER_RELOAD_P() (reload_status > DURING_RELOAD)
>>
>
> That seems quite elegant to me.
>
> cheers,
> DaveK
>
This seems like a reasonable idea.
I do not want to make this change myself: I prefer that this change be
made by someone who understands the backends well enough to simplify the
cases (not to mention the fact that there are 2000 grep hits of this
and there were only 200 of no_new_pseudos).
The purpose of my patch was to get rid of a variable that had not been
directly connected to reload. And in that sense, I believe that my
patch is a real simplification and a real step forward.
I consider this change is a logical follow on to my patch.
kenny
