> Jan Hubicka wrote on 04/14/07 16:14: > > > Looks great, still I think "locus" and "block" could be both merged into > > single integer, like RTL land has INSN_LOCATOR. > > That's the idea. But it's simpler to do this for now. The insn locator > is easily done at anytime during the implementation.
Sure, it can (and should) be done independently on the main transfomration to tuples. I just wondered if your document is documenting the final shape or what should be done during hte first transition. If the second, probably 2 words should be accounted for location as source_locues is currently a structure. > > > Also ssa_operands structures should be somewhere in the header and uid > > would be handy for on-side datastructures. > > No. SSA operands need to be split in the instructions that actually > need them. Also, UIDs are tempting but not really needed. I would only > consider them if using pointer-maps or hash tables gets outrageously > expensive. So you expect the ssa_operands to be associated via a hashtable or placed lower in the inheritance hiearchy? (the second is what I had in mind - surely it makes no sense to allocate them for labels, but they has to be somewhere). Concerning uids, it is always dificult to get some good data on this sort of thing. It seems to me that the UID would be handly and easy to bundle to some other integer, but it is not too important, especially if get some handy abstraction to map data with statements that we can easilly turn in between hashtables and arrays to see the difference instead of writting hasthables by hand in every pass doing this. > > > > In CFG getting rid of labels in GS_COND woulsd actually save us > > noticeable amount of memory by avoiding the need for labels. Perhaps we > > can simply define "true branch target"/"false branch target" to point to > > label or BB depending on CFG presence or to be NULL after CFG conversion > > and rely on CFG edges. GS_SWITCH would be harder, since association with > > CFG edges is not so direct. > > Sure, that would be something to consider. I have some data for this, lets discuss it at ICE. Honza
