Jan Hubicka wrote on 04/14/07 16:14: > Looks great, still I think "locus" and "block" could be both merged into > single integer, like RTL land has INSN_LOCATOR.
That's the idea. But it's simpler to do this for now. The insn locator is easily done at anytime during the implementation. > Also ssa_operands structures should be somewhere in the header and uid > would be handy for on-side datastructures. No. SSA operands need to be split in the instructions that actually need them. Also, UIDs are tempting but not really needed. I would only consider them if using pointer-maps or hash tables gets outrageously expensive. > In CFG getting rid of labels in GS_COND woulsd actually save us > noticeable amount of memory by avoiding the need for labels. Perhaps we > can simply define "true branch target"/"false branch target" to point to > label or BB depending on CFG presence or to be NULL after CFG conversion > and rely on CFG edges. GS_SWITCH would be harder, since association with > CFG edges is not so direct. Sure, that would be something to consider.
