On Fri, Apr 13, 2007 at 02:13:34PM -0700, Andrew Pinski wrote: > On 4/13/07, H. J. Lu <[EMAIL PROTECTED]> wrote: > >On Fri, Apr 13, 2007 at 12:04:04PM -0700, Andrew Pinski wrote: > >> On 4/13/07, H. J. Lu <[EMAIL PROTECTED]> wrote: > >> > >> You don't need to do all this, You can just use variable with MASK > >> which was added by JSM when PPC64-linux-gnu's target bits overflowed. > > > >For i386, we are adding new target mask bits for new instruction sets. > >The new bits are used togther with existing ISA bits to selectively > >enable builtins. I don't know how to make the new variable to work > >when a new variable will have a set of bits overlapping with the exist > >ones. For example, SSE2 has > > I mean you can move over all the ISA flags to their own mask variable > without changing the common part of the compilers as you can use MASK > and variable together in the .opt files. > > You don't need to have an extra option called ISA for these variables.
It won't work due to ;; Support Athlon 3Dnow builtins Mask(3DNOW_A) in i386.opt. It will put 3DNOW_A in target_flags even if I use ;; Support Athlon 3Dnow builtins Mask(3DNOW_A) Var(target_isa_flags) To put it on target_isa_flags, I have to add something like -m3dnowa But this option isn't needed before. Also it will change MASK_SSE to OPTION_MASK_SSE and change TARGET_SSE to OPTION_SSE. They look odd to me. H.J.
