On Thu, 18 Jan 2007, Joseph S. Myers wrote:

[...]

| > Furthermore, elsewhere (in the overflow thread) it has been suggested
| > that people should convert to the unsigned variants, do computations there,
| > and convert back to the signed variants.  We have just promised an
| > invariant that we will hold.
|
| The suggestion is for *explicit* conversions (casts), the warnings (should
| be) for implicit conversions.

Not just because a cast is explicit that it magically makes the
code more correct or safer.

In essence, what this warning is doing is to implicit suggest to add
casts, and basta it is done.  If the code is wrong before, it will
remain wrong after the cast.

Please do run the compiler on applications out there.  libstdc++
is a small scale libary (though an important one) that shows
the inappropriateness of the warnings; firefox is one I just built.
People should run more.

-- Gaby

Reply via email to