On Mon, Dec 11, 2006 at 12:27:07AM -0500, Daniel Berlin wrote: > Hey, by chance does the attached fix it? >
Yes, it fixes 464.h264ref with the test input. I am running the real input now. Thanks. H.J. --- > > On 12/10/06, Daniel Berlin <[EMAIL PROTECTED]> wrote: > >On 12/10/06, H. J. Lu <[EMAIL PROTECTED]> wrote: > >> 2006 > >> Reply-To: > >> > >> Hi Daniel, > >> > >> Do you have access to SPEC CPU 2006? > > > >No, i don't, only SPEC CPU 2000. > > > >> Your patch > >> > >> http://gcc.gnu.org/ml/gcc-patches/2006-12/msg00225.html > >> > >> causes gcc 4.3 to miscompile 464.h264ref in SPEC CPU 2006 with > >> -O2 -ffast-math on Linux/x86-64. 464.h264ref compiled with gcc 4.3 > >> generates incorrect output. We are working on a small testcase. > > > >There was a typo fix to this patch in a later revision that was > >necessary for correctness. I have no idea what rev "gcc 4.3" refers > >to, so i can't tell you if what you are testing is new enough or not > >:) > > > >If you can get me a testcase, i can fix it. > > > --- gcc/tree-ssa-structalias.c (/mirror/gcc-trunk) (revision 639) > +++ gcc/tree-ssa-structalias.c (/local/gcc-clean) (revision 639) > @@ -2885,6 +2885,8 @@ handle_ptr_arith (VEC (ce_s, heap) *lhsc > { > rhsoffset = TREE_INT_CST_LOW (op1) * BITS_PER_UNIT; > } > + else > + return false; > > > for (i = 0; VEC_iterate (ce_s, lhsc, i, c); i++) > > Property changes on: > ___________________________________________________________________ > Name: svk:merge > +138bc75d-0d04-0410-961f-82ee72b054a4:/trunk:119713 > +23c3ee16-a423-49b3-8738-b114dc1aabb6:/local/gcc-pta-dev:259 > +23c3ee16-a423-49b3-8738-b114dc1aabb6:/local/gcc-trunk:531 > +7dca8dba-45c1-47dc-8958-1a7301c5ed47:/local-gcc/md-constraint:113709 > +f367781f-d768-471e-ba66-e306e17dff77:/local/gen-rework-20060122:110130 >
