On Jun 26, 2006, at 9:01 AM, Bryce McKinlay wrote:

Otherwise, this is fine.

No it is not, it broke bootstrap on powerpc-darwin:
/Users/regress/tbox/svn-gcc/libjava/boehm.cc: In function 'void _Jv_SuspendThread(_Jv_Thread_t*)': /Users/regress/tbox/svn-gcc/libjava/boehm.cc:679: error: 'GC_suspend_thread' was not declared in this scope /Users/regress/tbox/svn-gcc/libjava/boehm.cc: In function 'void _Jv_ResumeThread(_Jv_Thread_t*)': /Users/regress/tbox/svn-gcc/libjava/boehm.cc:685: error: 'GC_resume_thread' was not declared in this scope

This is the fourth patch to libjava in the last two weeks which have caused a bootstrap failure on powerpc-darwin (and sometimes on other targets) so maybe it might be time to step
back for a second before approving/applying patches.


Thanks,
Andrew Pinski

Reply via email to