"Steven Bosscher" <[EMAIL PROTECTED]> writes:

> Does the code conform to the GNU/GCC coding conventions? You can find
> those on the gcc web site (http://gcc.gnu.org/codingconventions.html).

Hi,

thanks for the URL.

Generally yes - although the documentation needs more work to include
internal front end details (gm2 as of gcc-3.3.6 graft needed no tree
extensions).  The later graft will define its own tree.def to
implement SET_TYPE as previously advised etc. All gm2 command line
switches are documented in gm2/gm2.texinfo.

It would be good to restructure some of the gm2-gcc interface code,
into similar filenames to that used by other front ends. Ie
m2typeck.c, m2decl.c rather than the large single file gm2/gccgm2.c.
There is quiet a bit of pseudo duplication between gm2 and say the C
front end - it would be really good to reduce this if possible..

Regressions tests and ChangeLog entries have been coordinated for some
time now. Although they could adopt a more formal PR numbering scheme
as per gcc.

regards,
Gaius

Reply via email to