On Mon, Dec 26, 2005 at 11:34:16PM -0800, Geoff Keating wrote:
> We've had Real Problems with this feature since it was introduced. I
> expect it'll take at least another two or three months before it
> settles down and starts to work on most targets; that's only to be
> expected for such a far-reaching change to GCC's capabilities.
It works just fine on ELF targets on gcc-4_1-branch, where you haven't
applied your set of changes (as well as in the 4.0, 3.4 and 3.2 backports
Alex did).
More importantly, it is very wrong if GCC 4.1 and 4.2 weakrefs are
incompatible in their user visible part (trunk requires
static __typeof (bar) foo __attribute__ ((weakref ("bar")))
while 4.1 requires
extern __typeof (bar) foo __attribute__ ((weakref ("bar")))
).
IMHO this needs to be resolved before GCC 4.1 is released, so very soon.
Either someone needs to investigate all TREE_PUBLIC checks in whole GCC
and backport trunk changes to 4.1; I'd say this is pretty dangerous.
Or the trunk change needs to be reverted. Or perhaps 4.1 could keep
the static __typeof (bar) ... syntax, but internally set TREE_PUBLIC
in those cases (this will need some changes if we want to allow say
static __typeof (bar) foo;
...
static __typeof (bar) foo __attribute__ ((weakref ("bar")));
or
static __typeof (bar) foo __attribute__ ((weakref ("bar")));
...
static __typeof (bar) foo;
but I don't think they really need to be allowed).
Jakub
