>> While most of these changes appear to be correct, I see a regression on >> *-*-netware* (which by default uses packed structures) in >> gcc.dg/20030321-1.c, and I believe the warning tested for cannot be >> expected (since the code generating the warning tests >> >> TYPE_ALIGN (TREE_TYPE (*node)) <= BITS_PER_UNIT >> >> which cannot reasonably be expected to be true for 'long long'. > >Why not? If you don't get a warning for the attribute being >ignored then, your target doesn't really pack structures; maybe >we need to split default_packed into variants.
Actually, thinking more about it, I agree, the warning should be there, but is missing, because the condition for emitting it is wrong. >On the other hand, FWIW, I think the warning is generally bogus, >but I've already mentioned that. It should not only check TYPE_ALIGN (), but also consider current structure packing in effect (and consequently, it should also be emitted e.g. when #pragma pack(1) is in effect on a target that doesn't default to packed structures). Jan
